Skip to content

Expire deprecation on qargs=None in DAG appends#11190

Merged
ElePT merged 1 commit into
Qiskit:mainfrom
jakelishman:remove-dag-warns
Nov 6, 2023
Merged

Expire deprecation on qargs=None in DAG appends#11190
ElePT merged 1 commit into
Qiskit:mainfrom
jakelishman:remove-dag-warns

Conversation

@jakelishman
Copy link
Copy Markdown
Member

Summary

This removes the warnings converting explicit Nones into empty tuples, following its deprecation in 0.45.

Details and comments

Originally deprecated in #10752.

This removes the warnings converting explicit `None`s into empty tuples,
following its deprecation in 0.45.
@jakelishman jakelishman added the Changelog: Removed Add a "Removed" entry in the GitHub Release changelog. label Nov 3, 2023
@jakelishman jakelishman added this to the 1.0.0pre1 milestone Nov 3, 2023
@jakelishman jakelishman requested a review from a team as a code owner November 3, 2023 13:16
@qiskit-bot
Copy link
Copy Markdown
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6745686340

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.02%) to 86.952%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 91.92%
qiskit/pulse/library/waveform.py 3 93.75%
Totals Coverage Status
Change from base Build 6745236401: 0.02%
Covered Lines: 74363
Relevant Lines: 85522

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal LGTM.

@ElePT ElePT added this pull request to the merge queue Nov 6, 2023
Merged via the queue into Qiskit:main with commit 81e5ddd Nov 6, 2023
matthewscottconroy pushed a commit to matthewscottconroy/qiskit that referenced this pull request Nov 6, 2023
This removes the warnings converting explicit `None`s into empty tuples,
following its deprecation in 0.45.
matthewscottconroy pushed a commit to matthewscottconroy/qiskit that referenced this pull request Nov 6, 2023
This removes the warnings converting explicit `None`s into empty tuples,
following its deprecation in 0.45.
@jakelishman jakelishman deleted the remove-dag-warns branch November 6, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: Removed Add a "Removed" entry in the GitHub Release changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants